Model script exclusion via SourceExclusions and skip files entirely instead of placing them temporarily on the source path
#543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to the source path. The rationale for this is that language features would be provided even for excluded files, e.g. .kts scripts when `kotlin.scripts.enabled` is disabled or source files in auto-generated directories such as `./bin`.
According to detekt, this would have incurred a performance penalty.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the script extension checking logic introduced in #536 to
SourceExclusions. This lets us test, in a single place, whether a URI is tracked by the source path or not. Additionally, language features (i.e. completions, hovers etc.) are now only provided for included files, previouslyKotlinTextDocumentService.recoverforced these files onto the source path, largely subverting the exclusion logic and causing e.g. errors to show up in ignored files, if opened directly.