Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clicking the X button from the alt-tab screen quits FxSound #113

Closed
pie-flavor opened this issue Apr 29, 2024 · 3 comments
Closed

Clicking the X button from the alt-tab screen quits FxSound #113

pie-flavor opened this issue Apr 29, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@pie-flavor
Copy link

pie-flavor commented Apr 29, 2024

Describe the bug
In the alt-tab menu, there is an X button above the window preview and it is supposed to do the same thing as clicking the X button in the application. It does not. The X button in the application minimizes it to tray and the X button in the alt-tab screen quits the application.

To Reproduce
Steps to reproduce the behavior:

  1. Open FxSound from the tray menu.
  2. Hold Alt+Tab.
  3. While holding Alt+Tab, click the X button in the alt-tab preview.
  4. Observe that the application has fully quit and the audio device has been reset.

Expected behavior
The application to minimize to tray, same as the X button in the application.

Screenshots
image

System information

  • Windows version: 10 22H2 19045.4291
  • Audio device: Realtek drivers' virtual speakers
@doolhoofd doolhoofd added the enhancement New feature or request label Apr 29, 2024
@doolhoofd
Copy link

Okay... I've been running Windows since childhood, and have never heard of or used this function until today.
Perhaps it follows the tray icon's own logic into the Exit option?

Exit

Hi @bvijay74;
Just curious what your opinion on this one would be?

@bvijay74
Copy link
Member

I compared the Alt-Tab, preview window close button press behaviour in other applications. Application that minimise to the system tray are minimising and other task bar applications which don't have a system tray icon are closing.
To make FxSound behaviour similar to other system tray applications on Windows, we have to minimise it instead of quitting the application. We can look into the code changes required for this fix.

bvijay74 added a commit that referenced this issue Jul 7, 2024
Fix for issue #113 to prevent application closing from Alt+Tab switching
@bvijay74 bvijay74 self-assigned this Jul 12, 2024
@bvijay74
Copy link
Member

This issue is fixed in 1.1.24.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants