Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fix dateTimeBetween() Argument on Generator phpdoc #1583

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Fix dateTimeBetween() Argument on Generator phpdoc #1583

merged 1 commit into from
Sep 19, 2018

Conversation

hisomura
Copy link
Contributor

I'm sorry for my poor English.

Faker\Provider\DateTime::dateTimeBetween() has $timezone argument.
But dateTimeBetween() on Generator phpdoc does not have this argument.
I added it.

ppelgrims
ppelgrims reviewed Sep 19, 2018
View reviewed changes
Copy link
Contributor

@ppelgrims ppelgrims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you! (And don't worry about your English)

@fzaninotto fzaninotto merged commit 24525d2 into fzaninotto:master Sep 19, 2018
@fzaninotto
Copy link
Owner

Thanks.

@hisomura hisomura deleted the fix-phpdoc branch September 20, 2018 05:17
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ppelgrims ppelgrims ppelgrims left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hisomura @fzaninotto @ppelgrims