Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Created el_GR files for Company address #504

Merged
merged 2 commits into from
Sep 14, 2015

Conversation

drakakisgeo
Copy link
Contributor

Made some minor changes to the address file and created the company file for el_GR language.

@ronanguilloux
Copy link
Contributor

Hi @lollypopgr,

Thanks for your attempt to contribute to Faker! The Travis-CI continuous server answered to your commit with some litlle warnings: Not a big deal to fix ;-). This automatic check allows this project to remain stable & nice.

Just use the make sniff test command in a terminal, in your Faker project root folder, in order to have a review for your contribution style & non-regression. The command will respond you with some improvements to make this project stable & nice:

FILE: ...Faker/src/Faker/Provider/el_GR/Company.php
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
  4 | ERROR | Line indented incorrectly; expected 0 spaces, found 1
  5 | ERROR | Expected 0 spaces before opening brace; 1 found
 50 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 5
 59 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 5
 63 | ERROR | The closing brace for the class must go on the next line after the body
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

Have a look at PSR2 Standard Style to understand how to fix these unwanted spaces & bad closing braces positions.

We're looking forward to review your next commit ;-)

@fzaninotto
Copy link
Owner

Bump. Please fix the CS issues or I won't be able to merge this PR.

@drakakisgeo
Copy link
Contributor Author

Corrected this @ronanguilloux @fzaninotto . Sorry for the waiting.

fzaninotto added a commit that referenced this pull request Sep 14, 2015
Created el_GR files for Company address
@fzaninotto fzaninotto merged commit 56d5ed4 into fzaninotto:master Sep 14, 2015
@fzaninotto
Copy link
Owner

Thanks!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants