Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Improve name guesser logic using field length when available #606

Merged
merged 2 commits into from
Aug 24, 2015

Conversation

watermanio
Copy link

I kept finding dummy users with Lorem Ipsum as their salutation. This change uses the field length to be a bit more intelligent when that data is known. I've also tried to guess a few more column name and types.

…ctrine, Propel) and adds a few more field types.
public function guessFormat($name)
/**
* @param string $name
* @param int $size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int|null

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

fzaninotto added a commit that referenced this pull request Aug 24, 2015
Improve name guesser logic using field length when available
@fzaninotto fzaninotto merged commit 0df79fd into fzaninotto:master Aug 24, 2015
@fzaninotto
Copy link
Owner

Great patch, thanks!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants