This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Update Generator.php #632
Merged
Update Generator.php #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,7 +184,7 @@ public function seed($seed = null) | |||
| if ($seed === null) { | |||
| mt_srand(); | |||
| } else { | |||
| mt_srand($seed); | |||
| mt_srand(intval($seed)); | |||
There was a problem hiding this comment.
no trailing whitespace please
There was a problem hiding this comment.
Why not just use (int) $seed. It's exactly the same, but has better performance...
|
Thanks @GrahamCampbell, sorry for the trailing spaces :) |
| @@ -184,7 +184,7 @@ public function seed($seed = null) | |||
| if ($seed === null) { | |||
| mt_srand(); | |||
| } else { | |||
| mt_srand($seed); | |||
| mt_srand((int)$seed); | |||
There was a problem hiding this comment.
Should be (int) $seed.
|
An |
|
An empty one? |
|
Include a message explaining why you do this, something like: $this->assertTrue(true, 'seeding with a string doesn\'t throw an exception');Unfortunately , that's all phpUnit offers us to test that (cf sebastianbergmann/phpunit-documentation#171). |
|
ping @fzaninotto fast merge :) |
|
Thanks! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast
$seedinstead of checking ifnull. This way it does not throw an error if we passed a stringified int value either.