Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

How exactly do matrix types get converted between one another? #371

Closed
JesseTG opened this issue Jul 29, 2015 · 1 comment
Closed

How exactly do matrix types get converted between one another? #371

JesseTG opened this issue Jul 29, 2015 · 1 comment
Assignees
@Groovounet
Labels
bug
Milestone
GLM 0.9.7

Comments

@JesseTG
Copy link

JesseTG commented Jul 29, 2015

It feels like the matrix to convert should have its values in the upper left corner of the new matrix, with the rest filled by the identity matrix. The code doesn't do that, though, and I can't quite understand what it's really doing.
@Groovounet Groovounet added the bug label Aug 1, 2015
Groovounet added a commit that referenced this issue Aug 1, 2015
@Groovounet
Fixed matrix conversions and added unit tests #371
d6ae2fd
@Groovounet Groovounet added this to the GLM 0.9.7 milestone Aug 1, 2015
@Groovounet Groovounet self-assigned this Aug 1, 2015
@Groovounet
Copy link
Member

This was a bug which should be fixed in master branch for 0.9.7 release.

Thanks for reporting,
Christophe

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Groovounet Groovounet

Labels
bug
Projects
None yet
Milestone
GLM 0.9.7
Development

No branches or pull requests
2 participants
@Groovounet @JesseTG