Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run PHPStan as Github Action #2

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Run PHPStan as Github Action #2

merged 1 commit into from
Feb 15, 2022

Conversation

g105b
Copy link
Owner

@g105b g105b commented Feb 15, 2022

  • Depend on PHPUnit for development

In order to run the unit tests, PHPUnit is a hard dev
dependency, so I've included it in this commit, and now
I can run the unit tests as part of this PR.

  • Depend on PHPStan for development

This is for willdurand#89 - to ensure correct type hints are provided
to developers who use IDEs.

  • Fix object model of AcceptHeader interface

Fixes willdurand#89 - IDEs and PHPStan are happy with this implementation

  • Correct return type

  • Correct nonexistent Priority class to AcceptHeader

  • Improve typehint - allow looser type to be returned

  • Improve typehint - more accurate types as parameters

  • Improve typehint - more accurate generics as parameters

  • Expose script property - was only ever written

  • Properly typehint associative array

  • Typehint nullable string

  • Match typehints of parent method

  • Add PHPStan to CI

  • Configure PHPUnit versions for different PHP runtimes

  • Use real phpunit

* Depend on PHPUnit for development

In order to run the unit tests, PHPUnit is a hard dev
dependency, so I've included it in this commit, and now
I can run the unit tests as part of this PR.

* Depend on PHPStan for development

This is for willdurand#89 - to ensure correct type hints are provided
to developers who use IDEs.

* Fix object model of AcceptHeader interface

Fixes willdurand#89 - IDEs and PHPStan are happy with this implementation

* Correct return type

* Correct nonexistent Priority class to AcceptHeader

* Improve typehint - allow looser type to be returned

* Improve typehint - more accurate types as parameters

* Improve typehint - more accurate generics as parameters

* Expose script property - was only ever written

* Properly typehint associative array

* Typehint nullable string

* Match typehints of parent method

* Add PHPStan to CI

* Configure PHPUnit versions for different PHP runtimes

* Use real phpunit
@g105b g105b merged commit 91a9d73 into 89-type-hinting Feb 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant