clean up anon ref to executor ASAP

A reference to an anonymous method executor in IOmniTask is cleaned up as soon as possible. This allows OTL tasks to be executed from a package. 
[fixes #132]

OtlTaskControl.pas

@@ -35,10 +35,13 @@
 ///     Blog            : http://thedelphigeek.com
 ///   Contributors      : GJ, Lee_Nover, Sean B. Durkin
 ///   Creation date     : 2008-06-12
-///   Last modification : 2018-12-13
-///   Version           : 1.40b
+///   Last modification : 2019-03-22
+///   Version           : 1.40c
 ///</para><para>
 ///   History:
+///     1.40c: 2019-03-22
+///       - [sglienke] TOmniTaskExecutor.Cleanup clears reference to anonymous function executor.
+///         This allows tasks to be run from a package. [issue #132]
 ///     1.40b: 2018-12-13
 ///       - Fixed: If additional wait objects registered with RegisterWaitObject were
 ///         constantly signalled, timers were never called.
@@ -829,9 +832,9 @@     TOmniMessageInfo = record
     procedure GetMethodAddrAndSignature(const methodName: string;
       var methodAddress: pointer; var methodSignature: TOmniInvokeType);
     procedure GetMethodNameFromInternalMessage(const msg: TOmniMessage; var msgName: string;
-      var msgData: TOmniValue {$IFDEF OTL_Anonymous}; var func:
-      TOmniTaskControlInvokeFunction; var funcEx: TOmniTaskControlInvokeFunctionEx; var proc:
-      TProc<integer>; var taskFunc: TOmniTaskInvokeFunction {$ENDIF OTL_Anonymous});
+      var msgData: TOmniValue {$IFDEF OTL_Anonymous};
+      var func: TOmniTaskControlInvokeFunction; var funcEx: TOmniTaskControlInvokeFunctionEx;
+      var proc: TProc<integer>; var taskFunc: TOmniTaskInvokeFunction {$ENDIF OTL_Anonymous});
     function  GetOptions: TOmniTaskControlOptions;
     function  HaveElapsedTimer: boolean;
     procedure Initialize;
@@ -1726,7 +1729,7 @@ procedure TOmniTask.Terminate;
     if not otExecuting then
       otTerminateWillCallExecute := true;
   finally otCleanupLock.ExitWriteLock; end;
-  // TODO 1 -oPrimoz Gabrijelcic : This is very suspicious :(
+
   if otTerminateWillCallExecute then //call Execute to run at least cleanup code
     InternalExecute(true);
 end; { TOmniTask.Terminate }
@@ -2129,6 +2132,9 @@ procedure TOmniTaskExecutor.Cleanup;
 begin
   oteWorkerIntf := nil;
   FreeAndNil(oteTimers);
+  {$IFDEF OTL_Anonymous}
+  oteFunc := nil;
+  {$ENDIF OTL_Anonymous}
 end; { TOmniTaskExecutor.Cleanup }
 
 procedure TOmniTaskExecutor.DispatchCommMessage(newMsgHandle: TOmniTransitionEvent;

history.txt

@@ -2,6 +2,11 @@
 
 - New features:
   - [Jacek Laskowski] donated a new OTL icon (res\OTL.ico).
+
+- Bug fixes:
+  - [sglienke] A reference to an anonymous method executor in IOmniTask is
+    cleaned up as soon as possible. This allows OTL tasks to be executed
+    from a package. [issue #132] 
 
 3.07.7: 2019-02-23