This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
chore: make compiled_artifacts
public in ProjectCompileOutput
struct
#2671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request proposes a change to the
ProjectCompileOutput
struct by making thecompiled_artifacts
field public. The modification is required for the usage of extendingfoundry
to work with non-solc compilers likezksolc
for zkSync.Context:
Currently, the
compiled_artifacts
field is marked aspub(crate)
, making it accessible only within the same crate. This encapsulation poses a limitation when the struct is used as part of a larger build process where access tocompiled_artifacts
is needed.Rationale:
In effort to extend
foundry
support to zkSync ecosystem, direct access is needed to thecompiled_artifacts
field. You can see where we make use ofcompiled_artifacts
here.compiled_artifacts
public allows for more flexible post-compilation processes, including custom artifact handling, storage, and modifications tailored to specific use cases.Functionality Impact:
The proposed change will have no impact on existing functionality. It merely extends the accessibility of the
compiled_artifacts
field, enabling external crates to utilize the compiled bytecode. This change is backward-compatible and does not alter the behavior of any existing code that depends on theProjectCompileOutput
struct.Solution
Solution:
PR Checklist