Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Update strum #2724

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Update strum #2724

merged 2 commits into from
Feb 12, 2024

Conversation

richardpringle
Copy link
Contributor

Motivation

Simply (and hopefully) fixing the failures from the @dependabot PR -> #2718

Solution

Use the new name

PR Checklist

It's unfortunate that this is a breaking change, but I guess any dependency update is a breaking change...

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's not a breaking change, just a deprecation of the old name. The test failures were unrelated.

@DaniPopes DaniPopes merged commit 2c10774 into gakonst:master Feb 12, 2024
16 of 18 checks passed
@richardpringle
Copy link
Contributor Author

Thanks! It's not a breaking change, just a deprecation of the old name. The test failures were unrelated.

Isn't updating strum always a breaking change? In any case, thanks for accepting the PR!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants