Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

feat(abigen): use structs for outputs #664

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 9, 2021

Motivation

Closes #661

Solution

substitute output tuples that are structs with rust structs, same as inputs

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@mattsse mattsse force-pushed the matt/abiencoderv2-outputs branch from 412f2c8 to 27597cb Compare December 9, 2021 16:26
@mattsse mattsse force-pushed the matt/abiencoderv2-outputs branch from 11393ad to 1798b97 Compare December 9, 2021 16:39
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the quick fix! 👍🏼

@gakonst gakonst merged commit 59cf991 into gakonst:master Dec 9, 2021
@mattsse mattsse mentioned this pull request Dec 10, 2021
3 tasks
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
* stop tracking foundryup

* feat/cast: events added to interface

* refactor: deduplicate code between func and event codegen

* test: add events to codegen tests

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add return struct support from abigen function signatures
3 participants