Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

Enforce commutativity of ENS reverse resolution #996

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Enforce commutativity of ENS reverse resolution #996

merged 1 commit into from
Mar 8, 2022

Conversation

sbihel
Copy link
Contributor

@sbihel sbihel commented Mar 8, 2022

As specified in https://docs.ens.domains/dapp-developer-guide/resolving-names#reverse-resolution

PR Checklist

  • Added Tests
    • I'm not sure where to find a negative test.
  • Added Documentation
  • Updated the changelog

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Guess this adds an extra RPC Call, but not much we can do about it. Massive footgun otherwise. LGTM

@gakonst gakonst merged commit 1641be7 into gakonst:master Mar 8, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants