Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix setParameterValue bug #2279

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Fix setParameterValue bug #2279

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ad70775
fix: animation time error because of speed and precision
luzhuang Jul 28, 2024
3435cdf
feat: opt code
luzhuang Jul 29, 2024
e40be2d
feat: opt code
luzhuang Jul 29, 2024
e6a170e
feat: opt code
luzhuang Jul 29, 2024
6731c21
feat: opt code
luzhuang Jul 29, 2024
692b6af
feat: opt code
luzhuang Jul 29, 2024
dc9a18a
feat: opt code
luzhuang Jul 29, 2024
50fe5e9
feat: opt code
luzhuang Jul 29, 2024
6729113
feat: opt code
luzhuang Jul 29, 2024
32185a5
fix: setParameterValue bug
luzhuang Jul 31, 2024
18acf48
Merge branch 'dev/1.3' of github.com:oasis-engine/engine into fix/ani…
luzhuang Jul 31, 2024
521e072
feat: opt code
luzhuang Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/animation/Animator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export class Animator extends Component {
*/
setParameterValue(name: string, value: AnimatorControllerParameterValue) {
const parameter = this._animatorController?._parametersMap[name];
if (parameter && parameter.defaultValue !== value) {
if (parameter) {
this._parametersValueMap[name] = value;
}
}
Expand Down
Loading