Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update Python dependencies #17333

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Update Python dependencies #17333

merged 3 commits into from
Jan 30, 2024

Conversation

galaxybot
Copy link
Contributor

Run make update-dependencies.

@github-actions github-actions bot added this to the 24.0 milestone Jan 20, 2024
@nsoranzo
Copy link
Member

nsoranzo commented Jan 20, 2024 •
edited
Loading

Most test failures are due to the removal of FileResponse.send_header_only attribute in starlette 0.34.0 (PR), which we use in lib/galaxy/webapps/base/api.py::GalaxyFileResponse, e.g.:

   File "/home/runner/work/galaxy/galaxy/galaxy root/lib/galaxy/webapps/base/api.py", line 85, in __init__
    |     if not self.send_header_only and send_header_only:
    | AttributeError: 'GalaxyFileResponse' object has no attribute 'send_header_only'

@mvdbeek Can you take a look if you have time?

@galaxybot galaxybot force-pushed the dev_auto_update_dependencies branch from 22d3cf0 to 42e0222 Compare January 27, 2024 03:17
galaxybot and others added 2 commits January 30, 2024 16:39
@galaxybot @mvdbeek
Update Python dependencies
0c0da9c
@mvdbeek
Adapt to upstream FileResponse logic
e9d7b18 
The ``send_header_only`` attribute has been removed in starlette
(encode/starlette#2366), and replaced with
`scope["method"].upper() == "HEAD"`
@mvdbeek mvdbeek force-pushed the dev_auto_update_dependencies branch from 9c379b7 to e9d7b18 Compare January 30, 2024 15:39
nsoranzo
nsoranzo reviewed Jan 30, 2024
View reviewed changes
@mvdbeek @nsoranzo
Define variables
d08044c 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@mvdbeek mvdbeek force-pushed the dev_auto_update_dependencies branch from b6ec506 to d08044c Compare January 30, 2024 16:33
@nsoranzo nsoranzo merged commit ae711b1 into galaxyproject:dev Jan 30, 2024
52 of 53 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/dependencies kind/enhancement
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@galaxybot @nsoranzo @mvdbeek