Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[24.1] Determine expression tool output extension when input terminal #19364

Draft
wants to merge 2 commits into
base: release_24.1
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 20, 2024

Fixes #19245 by waiting for the dataset to become terminal if it's a expression.json dataset that we infer the output datatype from.
A slightly better implementation could look at the tool outputs when we generate the command line, which is when we're going to submit and have the terminal datasets ... ?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek force-pushed the determine_expression_tool_output_extension_when_input_terminal branch from eeacd6c to 5066bc2 Compare December 20, 2024 21:44
@mvdbeek
Copy link
Member Author

mvdbeek commented Dec 20, 2024

We might be adding objects to the sqlalchemy session (and maybe even committing them?) before hitting the ToolInputsNotReadyException. This would be a good place to use session.begin_nested() and session.rollback() to undo
staged changes, but I couldn't get that to work without changing the entire commit strategy.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant