Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rebuild schema, bump up minimum python version to 3.9 #113

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 28, 2025

That's dictated by schema-salad generating 3.9 syntax now. As an upside we do get much more useful validation errors.

@mvdbeek mvdbeek force-pushed the rebuild_autogenerated_python_Code branch from 003b937 to eb90c61 Compare February 28, 2025 11:03
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.03%. Comparing base (30571ba) to head (246ba3c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   41.03%   41.03%           
=======================================
  Files          51       51           
  Lines        1974     1974           
  Branches      441      441           
=======================================
  Hits          810      810           
  Misses       1047     1047           
  Partials      117      117           
Flag Coverage Δ
unittests 41.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsoranzo nsoranzo force-pushed the rebuild_autogenerated_python_Code branch from ffe80a1 to 2680dc2 Compare February 28, 2025 11:27
@nsoranzo
Copy link
Member

nsoranzo commented Feb 28, 2025

@mvdbeek Pushed a commit, but there's still a number of new mypy and unit errors to fix.

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 28, 2025

These seem like issues with schema-salad ? Any idea what is going on there @mr-c ?

@mr-c
Copy link
Contributor

mr-c commented Feb 28, 2025

These seem like issues with schema-salad ? Any idea what is going on there @mr-c ?

Which version of schema-salad did you use?

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 28, 2025

ahh, schema-salad-8.7.20241010092723, which i guess we pinned for 3.8 support. i'll try newer.

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 28, 2025

nice, thanks for the hint @mr-c !

@nsoranzo nsoranzo merged commit bb3b651 into galaxyproject:main Feb 28, 2025
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants