-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rebuild schema, bump up minimum python version to 3.9 #113
Rebuild schema, bump up minimum python version to 3.9 #113
Conversation
003b937
to
eb90c61
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 41.03% 41.03%
=======================================
Files 51 51
Lines 1974 1974
Branches 441 441
=======================================
Hits 810 810
Misses 1047 1047
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ffe80a1
to
2680dc2
Compare
@mvdbeek Pushed a commit, but there's still a number of new mypy and unit errors to fix. |
These seem like issues with schema-salad ? Any idea what is going on there @mr-c ? |
Which version of schema-salad did you use? |
ahh, schema-salad-8.7.20241010092723, which i guess we pinned for 3.8 support. i'll try newer. |
nice, thanks for the hint @mr-c ! |
That's dictated by schema-salad generating 3.9 syntax now. As an upside we do get much more useful validation errors.