Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixing linting issues and updating tools/abyss #6570

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SaimMomin12
Copy link
Contributor

@SaimMomin12 SaimMomin12 commented Nov 18, 2024

This PR updates the abyss tool to 2.3.10 and fixes some linting issues.

Fixes: #6490


FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a profile version for the tool.
Which linting issues have been fixed?

@@ -281,10 +281,10 @@ This tool performs the complete ABySS pipeline using abyss-pe, described in http
**License and citation**
This Galaxy tool is Copyright © 2015-2021 `Earlham Institute`_ and is released under the `MIT license`_.
This Galaxy tool is Copyright © 2015-2021 `Earlham Institute`_ and is released under the MIT license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a license attribute for the tool tag that could be used.

Isn't this trivial: You can use this tool only if you agree to the license terms .. since it's GPL3?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants