Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix d6 model #43

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Fix d6 model #43

merged 3 commits into from
Mar 23, 2020

Conversation

xgarrido
Copy link
Contributor

Testing d6 model (Vansyngel 2016 arXiv:1611.02577) with the current presets configuration was not working. Two things were broken:

  1. The initialization step was not passing some data members to the base class. Initialization of d6 model is fixed by 240b570. Some older data member (pixel_indices, for instance or MPI comm) have also been removed.

  2. The emission computation was done for a list of frequencies and then returning an emission per frequency, I, Q, U and number of pixels. Commit e5e5274 should address this, keeping the original code as much as possible (so, there might be room for optimization, numba for instance). The point is to integrate other frequencies at the end of d6 emission computation.

Data members of `super` class were not passed. Also remove useless parameters not used by any of the
base classes.
@zonca
Copy link
Member

zonca commented Mar 12, 2020

thanks! could you also contribute a unit test?

@xgarrido
Copy link
Contributor Author

Ok do I create another PR in https://github.com/healpy/pysm-data/tree/master/pysm_2_test_data or I put fits files somewhere and you will push them into pysm-data repository ?

@zonca
Copy link
Member

zonca commented Mar 12, 2020 via email

@xgarrido
Copy link
Contributor Author

xgarrido commented Mar 12, 2020

Done. I have used the same cryptic name for test data files but I see that for d7 model, you use a different pattern. I leave you change the name as you wish. Note that the computation at 353 GHz is buggy and so I skip the check for this frequency (btw it's working at 352 or 354 GHz...)

@zonca zonca merged commit d9fe9ca into galsci:master Mar 23, 2020
@xgarrido xgarrido deleted the fix-d6-model branch March 23, 2020 21:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants