Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
d6
model (Vansyngel 2016 arXiv:1611.02577) with the current presets configuration was not working. Two things were broken:The initialization step was not passing some data members to the base class. Initialization of d6 model is fixed by 240b570. Some older data member (
pixel_indices
, for instance or MPI comm) have also been removed.The emission computation was done for a list of frequencies and then returning an emission per frequency, I, Q, U and number of pixels. Commit e5e5274 should address this, keeping the original code as much as possible (so, there might be room for optimization,
numba
for instance). The point is to integrate other frequencies at the end ofd6
emission computation.