Use RUNNER_TEMP environment variable instead of a hardcoded path

[xanantis]

Because self-hosted runners can be placed anywhere, it is better to use an environment variable instead of a hardcoded path.

[codecov]

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files          16       16           
  Lines         378      378           
  Branches       72       72           
=======================================
  Hits          276      276           
  Misses         92       92           
  Partials       10       10           

Impacted Files	Coverage Δ
src/model/build-parameters.js	100.00% <ø> (ø)
src/model/docker.js	0.00% <ø> (ø)

[webbertakken]

Hi @xanantis and thank you for your PR.

I'm still trying to understand what you're trying to achieve and what exactly the use case is for this and how that use case would work. Could you perhaps elaborate a bit more on that?

Could you also tell us why you chose for an environment variable over an input variable and why you chose RUNNER_TEMP specifically?

Currently it looks like the default value is never set, which will likely break current behaviour. What are your thoughts on this?

[xanantis]

@webbertakken Variable is set by a runner. It leads to the temporary directory of the current runner. And it is always defined.
It is required when a self-hosted runner is installed in a different directory. Therefore has a different path to _temp directory.
There can be more than one runner on the same server.
If the path is hardcoded, they will use the same _temp directory.
And they will not clean it before each usage.

[webbertakken]

@xanantis Would you mind linking the source for this?

[xanantis]

@webbertakken Here is some info: runner-context.

And this is the result of:

- run: printenv

LEIN_HOME=/usr/local/lib/lein 
M2_HOME=/usr/share/apache-maven-3.6.3 
GOROOT_1_11_X64=/opt/hostedtoolcache/go/1.11.13/x64 
ANDROID_HOME=/usr/local/lib/android/sdk 
JAVA_HOME_11_X64=/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64 
ImageVersion=20200817.1 
AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache 
LANG=C.UTF-8 
AZURE_EXTENSION_DIR=/opt/az/azcliextensions 
POWERSHELL_DISTRIBUTION_CHANNEL=GitHub-Actions-ubuntu18 
GITHUB_API_URL=https://api.github.com 
INVOCATION_ID=99eb2ad2473447228243db10246e335c 
BOOST_ROOT_1_72_0=/opt/hostedtoolcache/boost/1.72.0/x64 
JAVA_HOME_12_X64=/usr/lib/jvm/adoptopenjdk-12-hotspot-amd64 
ANDROID_SDK_ROOT=/usr/local/lib/android/sdk 
RUNNER_TOOL_CACHE=/opt/hostedtoolcache 
SWIFT_PATH=/usr/share/swift/usr/bin 
JAVA_HOME=/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64 
JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8 
RUNNER_TRACKING_ID=github_70082c60-97b1-453e-8bdc-359eedc95114 
DOTNET_MULTILEVEL_LOOKUP="0" 
GITHUB_REPOSITORY_OWNER=xanantis 
GITHUB_ACTIONS=true 
DOTNET_SKIP_FIRST_TIME_EXPERIENCE="1" 
CI=true 
DOTNET_NOLOGO="1" 
USER=runner 
GITHUB_HEAD_REF= 
GITHUB_ACTOR=xanantis 
GITHUB_ACTION=run 
GRADLE_HOME=/usr/share/gradle 
PWD=/home/runner/work/runner-env/runner-env 
ImageOS=ubuntu18 
HOME=/home/runner 
GOROOT=/opt/hostedtoolcache/go/1.14.7/x64 
JOURNAL_STREAM=9:31069 
GOROOT_1_14_X64=/opt/hostedtoolcache/go/1.14.7/x64 
JAVA_HOME_8_X64=/usr/lib/jvm/adoptopenjdk-8-hotspot-amd64 
RUNNER_TEMP=/home/runner/work/_temp 
GOROOT_1_15_X64=/opt/hostedtoolcache/go/1.15.0/x64 
CONDA=/usr/share/miniconda 
GOROOT_1_13_X64=/opt/hostedtoolcache/go/1.13.15/x64 
BOOST_ROOT_1_69_0=/opt/hostedtoolcache/boost/1.69.0/x64 
DEBIAN_FRONTEND=noninteractive 
RUNNER_WORKSPACE=/home/runner/work/runner-env 
GITHUB_REF=refs/heads/master 
GITHUB_SHA=f19fcd722e8307cd32d75222102788532afd6610 
GITHUB_RUN_ID=219800958 
GITHUB_SERVER_URL=https://github.com 
GOROOT_1_12_X64=/opt/hostedtoolcache/go/1.12.17/x64 
GECKOWEBDRIVER=/usr/local/share/gecko_driver 
DEPLOYMENT_BASEPATH=/opt/runner 
GITHUB_EVENT_PATH=/home/runner/work/_temp/_github_workflow/event.json 
CHROMEWEBDRIVER=/usr/local/share/chrome_driver 
HOMEBREW_REPOSITORY="/home/linuxbrew/.linuxbrew/Homebrew" 
GITHUB_GRAPHQL_URL=https://api.github.com/graphql 
RUNNER_OS=Linux 
GITHUB_BASE_REF= 
VCPKG_INSTALLATION_ROOT=/usr/local/share/vcpkg 
GITHUB_JOB=print 
PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG 
JAVA_HOME_7_X64=/usr/lib/jvm/zulu-7-azure-amd64 
RUNNER_USER=runner 
SHLVL=1 
HOMEBREW_PREFIX="/home/linuxbrew/.linuxbrew" 
GITHUB_REPOSITORY=xanantis/runner-env 
GITHUB_EVENT_NAME=workflow_dispatch 
LEIN_JAR=/usr/local/lib/lein/self-installs/leiningen-2.9.4-standalone.jar 
GITHUB_RUN_NUMBER=1 
RUNNER_PERFLOG=/home/runner/perflog 
GITHUB_WORKFLOW=Runner Env 
ANT_HOME=/usr/share/ant 
PATH=/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games 
SELENIUM_JAR_PATH=/usr/share/java/selenium-server-standalone.jar 
GITHUB_WORKSPACE=/home/runner/work/runner-env/runner-env 
CHROME_BIN=/usr/bin/google-chrome 
HOMEBREW_CELLAR="/home/linuxbrew/.linuxbrew/Cellar" 
_=/usr/bin/printenv