Fix file ownership issues for runners. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbertakken
approved these changes
Aug 22, 2020
|
@xanantis Thanks. LGTM. By the way feel free to join us on https://unity-ci.com/discord if you like. |
caiusno1
added a commit
to caiusno1/unity-builder
that referenced
this pull request
Oct 9, 2020
webbertakken
pushed a commit
that referenced
this pull request
Oct 22, 2020
This was referenced Apr 13, 2021
4 tasks
|
This was reverted in #165 and two new solutions came up:
Follow developments there, or in their followups. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with file ownership after docker usage.
For Github Runners, it is required to call "sudo chown" to fix file ownership.
For Self-hosted Runners, it creates problems, if the user is not allowed to call sudo. One of the hacky solutions is to wrap the docker executable.
So, it is better, to build and run docker as the current user.