Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

allow versions with -alpha,-rc,-rc.0 .... + don't fail build on versi… #196

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

caiusno1
Copy link
Contributor

…on cannot be determined

Changes

  • Allow semantic versioning also for tag names which contain a following label -alpha, -alpha.0, -rc.0 ....
  • prevent the build from failing when semantic versioning can't match instead warn the user/developer
    related Issue: Build fails with 'Error: Failed to parse git describe output: "v0.1.0a-26-g6817b33' #163
  • (it is not completly semantic version hence the pattern check for a sequence of digit.digit.[...] (+ now -alpha ...) and append ., but enforcing strict semVers would need even more effort that I can't spend currently ....)

Remarks:

  • I didn't update all tests to check for the new possibilities only update the existing. Would be good for future work.

If you would like to merge I would appreciate, but I can understand if not because of lag of completeness. Unfortunately, I can't spend more time on it currently :/

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@codecov-io
Copy link

Codecov Report

Merging #196 (abfb951) into main (5b2e80e) will decrease coverage by 0.03%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   69.68%   69.65%   -0.04%     
==========================================
  Files          18       18              
  Lines         442      458      +16     
  Branches       97       98       +1     
==========================================
+ Hits          308      319      +11     
- Misses        123      128       +5     
  Partials       11       11              
Impacted Files Coverage Δ
src/model/versioning.js 95.00% <77.27%> (-5.00%) ⬇️

@webbertakken webbertakken merged commit 56b9864 into game-ci:main Jan 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants