Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix build script for Unity 2018, by using reflection instead of version defines #238

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

sbergen
Copy link
Contributor

@sbergen sbergen commented Mar 31, 2021

Changes

  • Use reflection instead of version defines to see if the addressables package is installed.

Fixes #233

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@webbertakken webbertakken merged commit 8419046 into game-ci:main Apr 2, 2021
@webbertakken
Copy link
Member

Great work! Thank you very much for fixing it across the board.

@sbergen sbergen deleted the FixAddressablesBuild2018 branch April 2, 2021 09:17
szymon-kazmierczak pushed a commit to zendesk/unity-builder that referenced this pull request Apr 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asmdef with conditional errors out on editor <= 2018
3 participants