Use find instead of glob for changing file permissions #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The build script passed the executable path to chmod inside quotes and therefore the glob patern (
.../MacOS/*
) did not get expanded by the shell. Chmod then returned an error, which you can see here, for example.I changed the script to use find to locate the executable file and run chmod on it. Using find still ensures that spaces in build path or build name are handled correctly.
I also swapped
StandaloneOSX.app
with$BUILD_NAME.app
so that the script works even if build name is changed.Checklist