Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use find instead of glob for changing file permissions #293

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

miscer
Copy link
Contributor

@miscer miscer commented Oct 21, 2021

Changes

The build script passed the executable path to chmod inside quotes and therefore the glob patern (.../MacOS/*) did not get expanded by the shell. Chmod then returned an error, which you can see here, for example.

I changed the script to use find to locate the executable file and run chmod on it. Using find still ensures that spaces in build path or build name are handled correctly.

I also swapped StandaloneOSX.app with $BUILD_NAME.app so that the script works even if build name is changed.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions
Copy link

Cat Gif

@codecov-commenter
Copy link

Codecov Report

Merging #293 (7845843) into main (8a836b8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   56.10%   56.10%           
=======================================
  Files          23       23           
  Lines         770      770           
  Branches      154      154           
=======================================
  Hits          432      432           
  Misses        337      337           
  Partials        1        1           

@webbertakken webbertakken merged commit e97ec82 into game-ci:main Oct 21, 2021
@miscer miscer deleted the fix-macos-permissions branch October 22, 2021 09:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants