Issue #317 #323
Merged
Issue #317 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @ninetyninereds I saw your comments earlier. LGTM. Does this work as expected for you? You could check using |
|
It does, already tried it in a private repository.
…On Mon, Jan 24, 2022 at 5:36 PM Webber Takken ***@***.***> wrote:
Hey @ninetyninereds <https://github.com/ninetyninereds> I saw your
comments earlier.
LGTM. Does this work as expected for you?
You could check using game-ci/unity-builder@<specific commit sha>
—
Reply to this email directly, view it on GitHub
<#323 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW3LGFN52FFQ23D6JFYR2ADUXVWY5ANCNFSM5MVTGW2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 23 23
Lines 781 781
Branches 151 151
=======================================
Hits 443 443
Misses 337 337
Partials 1 1
|
webbertakken
approved these changes
Jan 24, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added cwd: projectPath parameter to running of git in hasAnyVersionTags
Checklist