Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow Skipping Activation #629

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Allow Skipping Activation #629

merged 5 commits into from
Feb 19, 2024

Conversation

AndrewKahr
Copy link
Member

@AndrewKahr AndrewKahr commented Feb 18, 2024

Changes

  • Allow skipping activation. This is helpful for Mac self-hosted runners that may have multiple builds running simultaneously where the action activating/deactivating the license conflicts between jobs
  • Misc code cleanup
  • Package updates

Related PRs

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

Cat Gif

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (082ea39) 36.90% compared to head (9986ff3) 36.97%.

❗ Current head 9986ff3 differs from pull request most recent head 2a8058f. Consider uploading reports for the commit 2a8058f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   36.90%   36.97%   +0.06%     
==========================================
  Files          77       77              
  Lines        3116     3116              
  Branches      642      605      -37     
==========================================
+ Hits         1150     1152       +2     
- Misses       1823     1964     +141     
+ Partials      143        0     -143     
Files Coverage Δ
src/model/build-parameters.ts 90.00% <100.00%> (ø)
src/model/input.ts 88.59% <100.00%> (+0.15%) ⬆️
src/model/image-environment-factory.ts 4.00% <0.00%> (+0.29%) ⬆️

... and 35 files with indirect coverage changes

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@AndrewKahr AndrewKahr merged commit 4ae184c into main Feb 19, 2024
51 checks passed
@AndrewKahr AndrewKahr deleted the feature/skip-activation branch February 19, 2024 01:39
simon-homa pushed a commit to homagames/unity-builder that referenced this pull request Mar 7, 2024
* Add skipActivation functionality

* Update packages and fix lint/test issues

* Use nullish coalescing operator

* Ensure there is enough space for Android test builds
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants