Skip to content

Commit

Permalink
Add PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
ssiccha committed Sep 29, 2021
1 parent 6b50fd5 commit d911421
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
_Description of your PR_

# Checklist for the reviewer
## Functions constructing generators of maximal subgroups
- [ ] The code which computes and then stores the sizes is correct. To do this one confers to the tables referenced by the code. Tests for the group size should use `RECOG.TestGroup` from the recog package.
- [ ] The test suite checks whether all constructed generators are sensible. That is it tests the generators'
- [ ] determinants (and if applicable also the spinor norms are correct), and
- [ ] compatibility with the correct form.

## Functions assembling the list of all maximal subgroups of a certain group
The code agrees with the tables in section 8.2 of the book "The Maximal Subgroups of the Low-dimensional Finite Classical Groups".

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

0 comments on commit d911421

Please # to comment.