Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix source dist and wheels are not being built in CI #531

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jul 12, 2024

When trying to release a new version, I found that the build source dist and wheel step was being skipped due to the wrong variable. I also cleaned up some action usage and bumped the dependencies.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw requested a review from amolenaar July 12, 2024 02:17
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice bit of cleanup. Thanks 😊

@amolenaar amolenaar merged commit 87ee5e7 into main Jul 12, 2024
11 checks passed
@amolenaar amolenaar deleted the remove-skip-check branch July 12, 2024 05:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants