-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introduce make targets for sast and address security issues. #130
Conversation
This PR proposes changes that would break the pipeline definition:
|
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiyyakat thanks for the PR! I have a few minor comments. PTAL, thanks.
The pipeline-definition has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1904a5bda09c3616f1a6398973a802ed18e5cb91
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rishabh-11, shreyas-s-rao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR introduces two make targets:
sast
andsast-report
to rungosec
for Static Application Security Testing. It also addresses the security issues in the repository. The.ci/check
script now callsmake sast-report
to install and rungosec
.Which issue(s) this PR fixes:
Fixes #129
Special notes for your reviewer:
No changes made to the implementation. Only comments added to suppress
gosec
warnings wherever appropriate.Release note: