make ClusterFilter and StorageClass toggable in helm-chart
#830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
|
@nschad Thank you for your contribution. |
|
Thank you @nschad for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
gardener-robot
added
the
size/xs
|
|
nschad
force-pushed
the
helm-chart-toggable-resources
branch
from
7453cf1 to
a4ab011
Compare
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
/reviewed ok-to-test |
gardener-robot-ci-1
added
needs/ok-to-test
|
@nschad can you run |
Done. |
|
@nschad You need rebase this pull request with latest master branch. Please check. |
gardener-robot
removed
needs/review
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
nschad
force-pushed
the
helm-chart-toggable-resources
branch
from
d070d63 to
40cc790
Compare
|
/reviewed ok-to-test |
gardener-robot
added
the
reviewed/ok-to-test
kon-angelo
removed
the
needs/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
gardener-robot-ci-2
added
the
reviewed/ok-to-test
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform openstack
What this PR does / why we need it:
Allows the operator to configure whether he wants to deploy the
ClusterFiltersorStorageClassby default. This is required for us as we currently still have 2 Extensions registered on the sametype. Therefore we need to be able to configure in one extension, that certain things don't need to be deployed.To not change anything the default is implemented as always deploy just like before.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: