Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

forbid disabling share networks #885

Merged
merged 1 commit into from
Oct 22, 2024
Merged

forbid disabling share networks #885

merged 1 commit into from
Oct 22, 2024

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug
/platform openstack

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix an issue where provider-openstack required permissions for share network operations even when not required by the `InfrastructureConfig`.

@kon-angelo kon-angelo requested review from a team as code owners October 22, 2024 09:18
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/openstack OpenStack platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 22, 2024
hebelsan
hebelsan approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 22, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 22, 2024 •
edited
Loading

Testrun: e2e-4lnkg
Workflow: e2e-4lnkg-wf
Phase: Succeeded

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test         | Succeeded | 7m7s     |
| infrastructure-test | infrastructure-test-flow    | Succeeded | 6m6s     |
| infrastructure-test | infrastructure-test-migrate | Succeeded | 5m48s    |
| infrastructure-test | infrastructure-test-recover | Succeeded | 6m57s    |
| bastion-test        | bastion-test                | Succeeded | 4m21s    |
+---------------------+-----------------------------+-----------+----------+

@kon-angelo kon-angelo merged commit c14529a into gardener:master Oct 22, 2024
20 checks passed
@kon-angelo kon-angelo deleted the imm-manila branch October 22, 2024 10:48
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kon-angelo @AndreasBurger @hebelsan @gardener-robot-ci-1 @gardener-robot