Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove VPA for the csi-driver-node and csi-driver-manila-node DaemonSets #938

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Remove VPA for the csi-driver-node and csi-driver-manila-node DaemonSets #938

merged 2 commits into from
Dec 20, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Dec 18, 2024 •
edited
Loading

How to categorize this PR?

/area auto-scaling
/kind enhancement
/platform openstack

What this PR does / why we need it:
Similar to gardener/gardener-extension-provider-gcp#929

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

The kube-system/csi-driver-node and kube-system/csi-driver-manila-node DaemonSets are no longer scaled by a VerticalPodAutoscaler as they do not really benefit from it. Removing VerticalPodAutoscaler for these components will reduce unnecessary evictions by VPA and will be a mitigation for https://issues.k8s.io/126921.

@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure needs/review Needs review labels Dec 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Dec 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review December 18, 2024 15:18
@ialidzhikov ialidzhikov requested review from a team as code owners December 18, 2024 15:18
@ialidzhikov ialidzhikov marked this pull request as draft December 18, 2024 17:21
@ialidzhikov ialidzhikov marked this pull request as ready for review December 19, 2024 12:02
@ialidzhikov
Copy link
Member Author

I am sorry for all the back and forth with PR (marking ready for review and then draft).

tl;dr: It should be safe to remove VPA for the csi node plugin DaemonSet. The PR is ready for review!

hebelsan
hebelsan approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hebelsan hebelsan merged commit 5183e57 into gardener:master Dec 20, 2024
16 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Dec 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2024
@ialidzhikov ialidzhikov deleted the fix/remove-vpa-for-csi-driver-node branch December 24, 2024 08:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @hebelsan @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot