Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarify documentation and add doctests #58

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

jmr
Copy link
Contributor

@jmr jmr commented Dec 19, 2024

I found the semantics of push/push_increase/push_decrease somewhat unclear, so I reworded the docs and added doctest examples.

I found the semantics of `push`/`push_increase`/`push_decrease` somewhat
unclear, so I reworded the docs and added doctest examples.
@garro95
Copy link
Owner

garro95 commented Feb 1, 2025

Sorry for the late response, I missed this.

Thank you for your contribution. I find your wording much clearer and the doctest examples help to understand the semantic

@garro95 garro95 merged commit 59777a7 into garro95:master Feb 1, 2025
@garro95
Copy link
Owner

garro95 commented Feb 1, 2025

A similar change would be helpful for the DoublePriorityQueue too

@jmr
Copy link
Contributor Author

jmr commented Feb 1, 2025

Sure, I'll work on that.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants