[MGX-355] Node improvements & cleanups #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mateuszaaa
commented
Feb 14, 2023
•
mateuszaaa
commented
- improve sed cmd so its compatible with any docker image hardcoded
- Rename chainspecs: - 'kusama-mainnet' -> 'kusama' - 'local' -> 'kusama-local' - 'public-testnet' -> 'rococo' - 'mangata-rocococ-local-testnet' -> 'rococo-local'
- set alice as sudo in kusama-local chainspec
- assign corrent runtime name of the chainspec
- set Alice as sudo for rococo-local
- use new versioning convention that matches version from Github releases
- automatically build docker image that supports both mangata and kusama
- release single docker image for kusama & rococo
- Update readme file
- provide feelock palet genesis configuration
- update rococo & kusama chainspecs with genesis feelock configuration
- 'kusama-mainnet' -> 'kusama' - 'local' -> 'kusama-local' - 'public-testnet' -> 'rococo' - 'mangata-rocococ-local-testnet' -> 'rococo-local' Delete chainspecs: - 'dev'
mateuszaaa
force-pushed
the
feature/node-setup-cleanup
branch
from
9f2962b to
0fbc046
Compare
vanderian
reviewed
Feb 14, 2023
Comment on lines
+69
to
+72
| cd ./launch | ||
| yarn install | ||
| yarn gen | ||
| yarn up |
There was a problem hiding this comment.
can someone validate these steps? recently i had to call instead of the yarn gen
node_modules/.bin/parachain-launch generate
There was a problem hiding this comment.
I've tried it multiple times before and it was working fine.
That's how it is also being invoked in our pipeline.
| @@ -175,10 +175,10 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("mangata-parachain"), | |||
| impl_name: create_runtime_str!("mangata-parachain"), | |||
| authoring_version: 15, | |||
| spec_version: 15, | |||
| spec_version: 2800, | |||
There was a problem hiding this comment.
why such number ? v28.00 ?
There was a problem hiding this comment.
yep, more like 0.28.0, i expect 0.28.3 -> 0283
mateuszaaa
force-pushed
the
feature/node-setup-cleanup
branch
from
fd43a82 to
00769bb
Compare
mateuszaaa
force-pushed
the
feature/node-setup-cleanup
branch
from
00769bb to
c85ee3b
Compare
mateuszaaa
force-pushed
the
feature/node-setup-cleanup
branch
from
f1ffcb4 to
beb42e4
Compare
mateuszaaa
force-pushed
the
feature/node-setup-cleanup
branch
from
bcd6927 to
9298a00
Compare
mateuszaaa
force-pushed
the
feature/node-setup-cleanup
branch
from
9298a00 to
6b8cc48
Compare
iStrike7
previously approved these changes
Feb 25, 2023
… feature/node-setup-cleanup
tenequm
approved these changes
Feb 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.