Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI: Update Helm chart version for dev envs to fix issue with deprecated parameters MGX-808 #637

Conversation

tenequm
Copy link
Contributor

@tenequm tenequm commented Nov 9, 2023

@tenequm tenequm self-assigned this Nov 9, 2023
@tenequm tenequm added the 🚀 deploy Deploy fungible environment label Nov 9, 2023
@tenequm tenequm requested a review from vanderian November 9, 2023 13:08
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (935d846) 49.47% compared to head (d0bde6b) 49.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #637   +/-   ##
========================================
  Coverage    49.47%   49.47%           
========================================
  Files           34       34           
  Lines         6321     6321           
========================================
  Hits          3127     3127           
  Misses        3194     3194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -4,7 +4,7 @@ environment: {{ requiredEnv "ENVIRONMENT" | quote }}
image:
tag: {{ requiredEnv "IMAGE_TAG" | quote }}
customChainspecUrl: {{ .Values | get "nodeCustomChainspecUrl" "" }}
chain: {{ .Values | get "nodeChain" "rococo" }}
chain: {{ .Values | get "nodeChain" "mangata-rococo-local" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be just mangata-rococo ?
rococo previously it was the public testnet

mangata-rococo-local is a dev net
mangata-rococo is the public testnet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when nodeChain is configured as mangata-rococo-local, it at least tries to create blocks, but they are not getting propagated:
namespace pr-637
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frelaychain-alice-ws-pr-637.mangata.online#/explorer
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fnode-01-ws-pr-637.mangata.online#/explorer

when nodeChain is configured as mangata-rococo it doesn't produce any block at all:
namespace pr-6352
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frelaychain-alice-ws-pr-6352.mangata.online#/explorer
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fnode-01-ws-pr-6352.mangata.online#/explorer

@tenequm tenequm merged commit af46c18 into develop Nov 10, 2023
@tenequm tenequm deleted the ci/update-dev-env-helm-chart-to-fix-port-parameter-issue-MGX-808 branch November 10, 2023 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🚀 deploy Deploy fungible environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants