Add a test case for #259 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Rerunning tests to ensure they pass. |
|
Lint failed |
This currently fails. The change in gatsbyjs#259 will make it pass. Currently the image comes out at the wrong path (/hello-worldimage.jpg) ava doesnt have test.failing() yet, and our eslint config prevents the usage of test.todo() so this will most defininitely blow up travis.
benstepp
force-pushed
the
bs-pathrewrite
branch
from
386adc7 to
145b627
Compare
|
Rebased over master and force pushed for a new build on travis I guess I last minute fixuped too hard last night trying to remove noise from test fixtures. It would be nice if gatsby included a default _template, a default config, and a default html file if one isn't found. |
|
Agree re: defaults. I already did that with That should work given https://github.com/gatsbyjs/gatsby/blob/master/lib/utils/webpack.config.js#L127 |
|
Tests passed except for Node 6 + Mac OSX as currently node-sass won't install there. I'll merge then remove Node 6 from tests for now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails. The change in #259 will make it pass. Currently
the image comes out at the wrong path (/hello-worldimage.jpg)
ava doesnt have test.failing() yet, and our eslint config prevents the
usage of test.todo() so this will most defininitely blow up travis.