fix(gatsby): get-page-data should timeout gracefully #28131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
removed
the
status: triage needed
pieh
force-pushed
the
vladar/get-page-data-timeout
branch
from
81b2d6e
to
2be1f89
Compare
vladar
commented
Nov 19, 2020
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
pieh
approved these changes
Nov 19, 2020
pieh
added
the
bot: merge on green
vladar
added a commit
that referenced
this pull request
Nov 19, 2020
* fix(gatsby): get-page-data should timeout gracefully * lower timeout interval, add retries, make timeout configurable, add more tests * Update packages/gatsby/src/utils/__tests__/get-page-data.ts Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit c517b60)
pieh
pushed a commit
that referenced
this pull request
Nov 19, 2020
* fix(gatsby): get-page-data should timeout gracefully * lower timeout interval, add retries, make timeout configurable, add more tests * Update packages/gatsby/src/utils/__tests__/get-page-data.ts Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit c517b60)
This was referenced Jul 22, 2022
This was referenced Jul 22, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a timeout and retries to
getPageDatautility introduced in #27939Also adds missing test coverage.
All credits for this PR go to @pieh 😄