Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(gatsby): upgrade socket.io #29765

Merged
merged 2 commits into from
Feb 25, 2021
Merged

chore(gatsby): upgrade socket.io #29765

merged 2 commits into from
Feb 25, 2021

Conversation

wardpeet
Copy link
Contributor

Description

Upgrading socket.io to latest version - subset of #29699

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 25, 2021
ascorbic
ascorbic reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESM import syntax has changed in v3: https://socket.io/docs/v3/server-initialization/index.html

@ascorbic ascorbic added type: chore and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 25, 2021
@wardpeet wardpeet merged commit 3ab492c into master Feb 25, 2021
@wardpeet wardpeet deleted the v3/socket-io branch February 25, 2021 12:53
@gatsbybot gatsbybot mentioned this pull request Feb 25, 2021
Merged
ascorbic pushed a commit that referenced this pull request Feb 25, 2021
@wardpeet @ascorbic
chore(gatsby): upgrade socket.io (#29765)
3703f25 
* chore(gatsby): upgrade socket.io

* fix types

(cherry picked from commit 3ab492c)
ascorbic pushed a commit that referenced this pull request Feb 25, 2021
@wardpeet
chore(gatsby): upgrade socket.io (#29765) (#29769)
180ebad 
* chore(gatsby): upgrade socket.io

* fix types

(cherry picked from commit 3ab492c)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
This was referenced Feb 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 7, 2021
Closed
Closed
Closed
This was referenced May 5, 2021
Open
Open
Open
Open
Open
Open
@0xSebin 0xSebin mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 30, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 30, 2022
Open
@0xSebin 0xSebin mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
@nidhi42 nidhi42 mentioned this pull request Oct 31, 2022
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
This was referenced Oct 31, 2022
Open
Open
@kaocher82 kaocher82 mentioned this pull request Oct 31, 2022
Open
This was referenced Oct 31, 2022
Open
Open
Open
@nidhi42 nidhi42 mentioned this pull request Dec 6, 2023
Open
@tonyg101 tonyg101 mentioned this pull request Dec 6, 2023
Open
This was referenced Dec 6, 2023
Open
Open
@monizb monizb mentioned this pull request Dec 6, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Dec 7, 2023
Open
@wizbit wizbit mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 7, 2023
Open
Open
Open
@impactyogi impactyogi mentioned this pull request Dec 7, 2023
Open
@joeawillis joeawillis mentioned this pull request Dec 7, 2023
Open
This was referenced Dec 7, 2023
Open
Open
@impactyogi impactyogi mentioned this pull request Dec 8, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wardpeet @ascorbic