Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[v2] Upgrade to v3 #3126

Merged
merged 3 commits into from
Jan 11, 2018
Merged

[v2] Upgrade to v3 #3126

merged 3 commits into from
Jan 11, 2018

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Dec 4, 2017

upgrades web pack to v3 and updates the webpack-utils api to be more consistent.

I’d like to just user webpack-atoms and remove a bunch of code here, but at the moment it’s not structured super well for the gatsby use-case i need to change stuff a bit

@ghost ghost assigned jquense Dec 4, 2017
@ghost ghost added the review label Dec 4, 2017
upgrades web pack to v3 and updates the webpack-utils api to be more
consistent.
@jquense
Copy link
Contributor Author

jquense commented Dec 7, 2017

so i'm fairly sure the only reason Appveyor is failing is because the build setup for example sites uses gatsby-dev which doesn't handle updates to depedencies, so its using webpack1

@RomanHotsiy
Copy link
Contributor

Hey @jquense,

Great job with this! Any ETA when this PR is merged?
Can I help somehow?

@jquense
Copy link
Contributor Author

jquense commented Jan 5, 2018

i'm theoretically waiting for @KyleAMathews new testing infrastructure so i can properly test this. IF you need webpack 2+ support the current gatsby v2 prereleases already have v2, this is just a minor upgrade to v3 there

@scottyeck
Copy link
Contributor

Also happy to pitch in if I can. @jquense KILLER work putting a dent in the webpack upgrades.

@jquense
Copy link
Contributor Author

jquense commented Jan 5, 2018

Just to be clear folks :) this is a PR to the v2 branch it won't make it into gatsby v1

thanks for the offers of help, this is done really, we just need to get some testing done

@KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews changed the title Upgrade to v3 [v2] Upgrade to v3 Jan 11, 2018
@KyleAMathews
Copy link
Contributor

@jquense assuming this is good to go :-)

@KyleAMathews KyleAMathews merged commit f20ac0e into v2 Jan 11, 2018
@ghost ghost removed the review label Jan 11, 2018
@KyleAMathews KyleAMathews deleted the upgrade-webpack branch January 11, 2018 14:59
@KyleAMathews
Copy link
Contributor

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants