fix(gatsby-link): Correctly export default for CJS #36312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: core
pieh
force-pushed
the
fix/gatsby-link/jest2
branch
from
e351ecc to
0b8c651
Compare
…oduce new index-cjs module for wrapping
pieh
force-pushed
the
fix/gatsby-link/jest2
branch
from
6354777 to
9ef8c12
Compare
LekoArts
approved these changes
Aug 4, 2022
LekoArts
changed the title
LekoArts
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using microbundle with CJS output, it behaves differently than our babel transpilation.
Babel is adding
__esModule: truewhen moving from ES to CJS. Microbundle is not. This cause problems later on when using tools like jest, that runs transforms through babel usually. Babel's interops for imports/requires do check for__esModule, if it's not there weird things happen.Microbundle doesn't have option to add it, but Rollup that is used under the hood does:
We did find few issues on microbundle repo that seem related, but this setup seems like it's desired by maintainers and the workaround they provided (manually adding this export) is more-or-less what this PR adds
Related Issues
Fixes #36298