fix(gatsby-source-drupal): await async handleDeletedNode #37435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
approved these changes
Jan 10, 2023
TylerBarnes
added
topic: source-drupal
TylerBarnes
added
the
bot: merge on green
kathmbeck
approved these changes
Jan 10, 2023
tyhopp
pushed a commit
that referenced
this pull request
Jan 13, 2023
await async handleDeletedNode (cherry picked from commit e575a0a)
tyhopp
pushed a commit
that referenced
this pull request
Jan 13, 2023
await async handleDeletedNode (cherry picked from commit e575a0a)
tyhopp
pushed a commit
that referenced
this pull request
Jan 13, 2023
tyhopp
pushed a commit
that referenced
this pull request
Jan 13, 2023
|
Published in:
|
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 27, 2023
This was referenced May 31, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This async function isn't being awaited. I have a theory this is causing a problem for large sites (or maybe for all sites randomly) but I haven't verified that. This should be awaited either way though so should be good to merge.