Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(gatsby-adapter-netlify): handler generation on windows #38900

Merged
merged 28 commits into from
Apr 10, 2024
Merged

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 13, 2024

Description

This fixes quite a bit of windows specific issues:

  • (core) API functions compilation problems (path manipulation for require args had windows paths which can't be used)
  • (core) handler produced on non-linux platform was unusable when deployed due to LMDB and sharp binaries - this allow to "cross-compile" and deploy from windows to linux - new CLI toggles and env vars were added to control target, but by default when using Netlify adapter we will target linux/x64. There will be meaningful error message shown when incompatible binaries were used mentioning toggles to use
  • (adapter) function wrapper had windows paths in require args which can't be used

Tests

Smoke test building and deploying our adapters e2e test site on Windows and doing very brief/smoke test (can we hit index/SSG page, can we hit SSR page and get successful render was added)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 13, 2024
@pieh pieh added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 18, 2024
This was referenced May 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

3 participants