New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix pages-writer.js tests on win32 #7907

Merged

KyleAMathews merged 1 commit into gatsbyjs:master from pieh:write-pages-windows-tests

Sep 6, 2018

Contributor

pieh commented Sep 5, 2018

my bad for not waiting on appveyor when merging #7878

pieh changed the title ~~use path.join to fix appveyor tests~~ fix pages-writer.js tests on win32


          use same path joiner as pages-writer for tests

6f0f3da

pieh force-pushed the write-pages-windows-tests branch from a977746 to 6f0f3da Compare

September 5, 2018 22:20

DSchau approved these changes

View reviewed changes

Contributor

DSchau left a comment

Looks good. You could probably clean up the var args with a .split (e.g. my/gatsby/project/.cache/data.json.${now}`.split('/')) but this works!

KyleAMathews approved these changes

View reviewed changes

KyleAMathews merged commit b4c1472 into gatsbyjs:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet