fix: ensure graphql key (starting with numeric) is valid

[eLod]

handling keys that start with numeric, see #4000

[pieh]

Hey @eLod, could you also add some tests here - to this inline fixture

gatsby/packages/gatsby/src/schema/__tests__/infer-graphql-type-test.js

Lines 58 to 111 in 7132443

	const nodes = [
	{
	id: `foo`,
	name: `The Mad Max`,
	type: `Test`,
	"key-with..unsupported-values": true,
	hair: 1,
	date: `1012-11-01`,
	anArray: [1, 2, 3, 4],
	aNestedArray: [[1, 2, 3, 4], [5, 6, 7, 8]],
	anObjectArray: [
	{ aString: `some string`, aNumber: 2, aBoolean: true },
	{ aString: `some string`, aNumber: 2, anArray: [1, 2] },
	{ anotherObjectArray: [{ bar: 10 }] },
	],
	deepObject: {
	level: 1,
	deepObject: {
	level: 2,
	deepObject: {
	level: 3,
	},
	},
	},
	"with space": 1,
	"with-hyphen": 2,
	"with resolver": `1012-11-01`,
	aBoolean: true,
	externalUrl: `https://example.com/awesome.jpg`,
	domain: `pizza.com`,
	frontmatter: {
	date: `1012-11-01`,
	title: `The world of dash and adventure`,
	blue: 100,
	},
	},
	{
	id: `boo`,
	name: `The Mad Wax`,
	type: `Test`,
	hair: 2,
	date: `1984-10-12`,
	anArray: [1, 2, 5, 4],
	aNestedArray: [[1, 2, 3, 4]],
	anObjectArray: [{ anotherObjectArray: [{ baz: `quz` }] }],
	"with space": 3,
	"with-hyphen": 4,
	frontmatter: {
	date: `1984-10-12`,
	title: `The world of slash and adventure`,
	blue: 10010,
	},
	},
	]

) and some test running queries against that in that file for more "integration" like coverage of this?

[eLod]

@pieh sure, just to be sure: so you want me to add a value to that nodes elements with a key like 123 and check that the graphql has keys _123 right? and put into this test:

gatsby/packages/gatsby/src/schema/__tests__/infer-graphql-type-test.js

Line 231 in 7132443

it(`Handle invalid graphql field names`, async () => {

do you want me to add multiple keys or just a single one?

[pieh]

Yeah, this sounds good! 👍

[pieh]

Looking good! Just waiting for appveyor to finish before merging :)

[pieh]

Thanks @eLod!

[gatsbot]

Holy buckets, @eLod — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!