Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Check for color support whether printing colored sentences. #8

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

pliniosilveira
Copy link

Check for color support whether printing colored sentences.

Also changed print functions name to match PIP8 pattern
(https://www.python.org/dev/peps/pep-0008/#function-names)

Check for color support whether printing colored sentences.

Also changed print functions name to match PIP8 pattern
(https://www.python.org/dev/peps/pep-0008/#function-names)
@gautamkrishnar gautamkrishnar merged commit 3d4a248 into gautamkrishnar:master Jun 24, 2016
@gautamkrishnar
Copy link
Owner

Thanks a lot @Plinio89s for letting me know this and for the PR 👍 😄

@pliniosilveira
Copy link
Author

My pleasure!
There's something wrong to the CI configuration. Are you aware and planned to fix that?

@gautamkrishnar
Copy link
Owner

@Plinio89s Yes i am still configuring it

@gautamkrishnar
Copy link
Owner

@Plinio89s i lost color on windows 10, Windows 10 supports colors:

Before

screenshot 65

After

screenshot 64

any idea on how to fix it?

@pliniosilveira
Copy link
Author

I noticed this side effect. I tried to find a solution but I couldn't, so I let the code exactly as it is in django. i.e. on windows terminal always shows without color. (Of course if this side effect bothers you, I won't be sad if you take the code away.) :)

@gautamkrishnar
Copy link
Owner

@Plinio89s i think i can detect windows version and set it back... Thank you...

@gautamkrishnar
Copy link
Owner

Fixed that issue 😄 @Plinio89s

gautamkrishnar added a commit that referenced this pull request Jun 25, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants