-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update windows binary #327
Conversation
Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
- rename environment to use gz prefix - all libraries are available for Windows with the libgz prefix - fix old ignition package prefix Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
If you want to also install the Python bindings in the package that have them, you can install the gz- packages instead of the libgz- packages (this is something new in garden, see conda-forge/libignition-cmake0-feedstock#26 (comment)). |
Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@traversaro Thanks for the hint. I've added your naming scheme with my latest commit. |
@traversaro does this mean Gazebo works on windows without any issues? |
No, sorry if I gave that impression. The major Windows blocker are relocability issues (see gazebosim/gz-sim#168 (comment)), I have some patches for that in gazebosim/gz-sim#626 (comment) . I plan to clean them up and submit them upstream. As these patches change the public API/ABI, I am not confident backporting them in conda-forge as if then the review change them, it would be tricky to mantain the API/ABI symbols introduced by the outdated patches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Okay, thanks for clarifying. |
Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
🦟 Bug fix
Summary
Fixes use of old
ignition
package name, all packages are available for Windows (sdformat as well) and rename of Conda environment.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.