Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update windows binary #327

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Update windows binary #327

merged 4 commits into from
Dec 21, 2022

Conversation

Bi0T1N
Copy link
Contributor

@Bi0T1N Bi0T1N commented Dec 17, 2022

🦟 Bug fix

Summary

Fixes use of old ignition package name, all packages are available for Windows (sdformat as well) and rename of Conda environment.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
- rename environment to use gz prefix
- all libraries are available for Windows with the libgz prefix
- fix old ignition package prefix

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@Bi0T1N Bi0T1N requested a review from mabelzhang as a code owner December 17, 2022 15:34
@github-actions github-actions bot added the 🌱 garden Gazebo Garden label Dec 17, 2022
@traversaro
Copy link
Contributor

If you want to also install the Python bindings in the package that have them, you can install the gz- packages instead of the libgz- packages (this is something new in garden, see conda-forge/libignition-cmake0-feedstock#26 (comment)).

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@Bi0T1N
Copy link
Contributor Author

Bi0T1N commented Dec 18, 2022

@traversaro Thanks for the hint. I've added your naming scheme with my latest commit.

@azeey
Copy link
Contributor

azeey commented Dec 19, 2022

@traversaro does this mean Gazebo works on windows without any issues?

@azeey azeey self-requested a review December 19, 2022 19:44
@traversaro
Copy link
Contributor

traversaro commented Dec 20, 2022

@traversaro does this mean Gazebo works on windows without any issues?

No, sorry if I gave that impression. The major Windows blocker are relocability issues (see gazebosim/gz-sim#168 (comment)), I have some patches for that in gazebosim/gz-sim#626 (comment) . I plan to clean them up and submit them upstream. As these patches change the public API/ABI, I am not confident backporting them in conda-forge as if then the review change them, it would be tricky to mantain the API/ABI symbols introduced by the outdated patches.

Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@azeey
Copy link
Contributor

azeey commented Dec 21, 2022

Okay, thanks for clarifying.

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
@azeey azeey merged commit 7fac0de into gazebosim:master Dec 21, 2022
@Bi0T1N Bi0T1N deleted the update_windows_binary branch April 27, 2023 12:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🌱 garden Gazebo Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants