Generate valid visibility macros by replacing hyphens in component name

[j-rivero]

For cases where ign_add_component is being called using a name with hyphens, ign-cmake will generate a visibility macro using the hyphens, which is an invalid character. The PR changes two things:

• Safety internal check to error on presence of hyphens
• Patch _ign_add_library_or_component to replace the hyphens by underscores

If you want to see the problem in action, create a colcon workspace for ign-gazebo and use the win branch. This is the kind of error it generates:

In file included from /tmp/ign-gazebo/src/systems/air_pressure/AirPressure.hh:22,
                 from /tmp/ign-gazebo/src/systems/air_pressure/AirPressure.cc:18:
/var/lib/jenkins/workspace/ignition_gazebo-abichecker-any_to_any-ubuntu_auto-amd64/build/include/ignition/gazebo/air-pressure-system/Export.hh:25:28: warning: extra tokens at end of #ifndef directive
 #ifndef IGNITION_GAZEBO_AIR-PRESSURE-SYSTEM_EXPORT_HH_
                            ^
/var/lib/jenkins/workspace/ignition_gazebo-abichecker-any_to_any-ubuntu_auto-amd64/build/include/ignition/gazebo/air-pressure-system/Export.hh:26:28: warning: ISO C++11 requires whitespace after the macro name
 #define IGNITION_GAZEBO_AIR-PRESSURE-SYSTEM_EXPORT_HH_

[mjcarroll]

LGTM, is there some way we can run a full CI to make sure that it doesn't impact anything downstream?

[j-rivero]

LGTM, is there some way we can run a full CI to make sure that it doesn't impact anything downstream?

umm, the out-of-the-box implementation I can think of is using the colcon windows builds with a custom gazebodistro using this branch. Here is a rendering one:

[mjcarroll]

Okay, the current build failures here are because of #134, fixed by #138 . Let's wait and land that first so we can see the actions turn green here.

[mjcarroll]

@j-rivero Sorry, it just looks like this needs a DCO signoff now.

[chapulina]

Rebased and fixed DCO. Merging 👍