Avoid duplication of / in joinPaths (Windows)

[ahcorde]

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Fixes #

Related with this issue gazebosim/gz-fuel-tools#178

Summary

When we use JoinPaths with a empty string we can have some extra ' /' which generates some issues on Windows. As a explained here. This PR remove the '/' at the beginning and end of the string.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #201 (3798dea) into ign-common3 (72820ee) will decrease coverage by 0.00%.
The diff coverage is 84.61%.

❗ Current head 3798dea differs from pull request most recent head 4b27357. Consider uploading reports for the commit 4b27357 to get more accurate results

@@               Coverage Diff               @@
##           ign-common3     #201      +/-   ##
===============================================
- Coverage        75.08%   75.08%   -0.01%     
===============================================
  Files               72       72              
  Lines            10261    10273      +12     
===============================================
+ Hits              7704     7713       +9     
- Misses            2557     2560       +3     

Impacted Files	Coverage Δ
include/ignition/common/Filesystem.hh	100.00% <ø> (ø)
src/Filesystem.cc	73.98% <84.61%> (+0.69%)	⬆️
graphics/src/SkeletonAnimation.cc	42.46% <0.00%> (-1.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72820ee...4b27357. Read the comment docs.

[chapulina]

Can we add some test cases that demonstrate the fix? Also, should we make the behavior consistent across platforms?

[ahcorde]

Also, should we make the behavior consistent across platforms?

I can remove the / at the end of the string, but at the beginning of the string in an Unix like system is a bad idea because I can modify an absolute path

[ahcorde]

MacOS warnings are unrelated

[chapulina]

I pushed a test in 6c4f5d6, LGTM if it passes.

[ahcorde]

MacOS warnings are unrelated