Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove raw new/delete calls from #205 #206

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

mjcarroll
Copy link
Contributor

I think that we should generally avoid raw new and delete calls in code going forward. In this case, the test was also allocating memory without deallocating.

I replaced heap allocations with std::vector<T> where it made sense.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from iche033 April 26, 2021 19:39
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #206 (260c42c) into convert_rgb (fe9fffe) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           convert_rgb     #206      +/-   ##
===============================================
- Coverage        75.21%   75.20%   -0.02%     
===============================================
  Files               73       73              
  Lines            10309    10307       -2     
===============================================
- Hits              7754     7751       -3     
- Misses            2555     2556       +1     
Impacted Files Coverage Δ
graphics/include/ignition/common/Image.hh 97.05% <100.00%> (-0.17%) ⬇️
graphics/src/SkeletonAnimation.cc 42.46% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9fffe...260c42c. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@mjcarroll mjcarroll merged commit 90eba51 into convert_rgb Apr 27, 2021
@mjcarroll mjcarroll deleted the mjcarroll/convert_rgb branch April 27, 2021 12:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants