Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use relative install paths for plugin shared libraries and gz-tools data #614

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

🦟 Bug fix

Summary

Fixes an error when building https://github.com/gazebo-release/gz_gui_vendor/ in the ROS buildfarm.

Similar to gazebosim/gz-tools#137

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…data

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from jennuine as a code owner April 4, 2024 17:15
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (b252bd0) to head (c89e734).

Additional details and impacted files
@@           Coverage Diff            @@
##           gz-gui8     #614   +/-   ##
========================================
  Coverage    70.09%   70.09%           
========================================
  Files           39       39           
  Lines         5363     5363           
========================================
  Hits          3759     3759           
  Misses        1604     1604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey requested a review from caguero April 9, 2024 16:27
@azeey azeey changed the title Use relative install paths for plugin shared librariesi and gz-tools data Use relative install paths for plugin shared libraries and gz-tools data Apr 10, 2024
@azeey
Copy link
Contributor Author

azeey commented Apr 10, 2024

This can be tested by going into the build directory and running

cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -P cmake_install.cmake

(Make sure to have the latest version of gz-cmake3)

@azeey azeey merged commit 648c8b7 into gz-gui8 Apr 10, 2024
11 checks passed
@azeey azeey deleted the azeey/rel_paths branch April 10, 2024 21:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants